Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/androidx navigation tracing #2137

Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 24, 2022

#skip-changelog

📜 Description

  • Adds tracing support for Jetpack Compose Navigation
  • Uses idle transactions (similar to UI events)

image

💡 Motivation and Context

Part of #2096

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn requested a review from marandaneto as a code owner June 24, 2022 15:15
@romtsn romtsn mentioned this pull request Jun 24, 2022
9 tasks
@romtsn romtsn requested a review from adinauer June 24, 2022 18:21
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM just some questions.

@romtsn romtsn merged commit 727b55e into feat/compose-navigation-support Jun 29, 2022
@romtsn romtsn deleted the feat/androidx-navigation-tracing branch June 29, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants