New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make upstream dependencies compileOnly in integrations #2175
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe @adinauer or @marandaneto want to 馃憖 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe we should add more detail to the error messages somewhere.
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃殌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
馃摐 Description
Switch to compileOnly upstream dependencies in integrations, so we do not override user-defined version and use what they actually have on their classpath.
馃挕 Motivation and Context
Closes #2125
馃挌 How did you test it?
Tested manually here and on SAGP
馃摑 Checklist
馃敭 Next steps
@adinauer I'm not sure if you want to do this for backend things, I think it can also be applicable there? We could create another issue, for now I'm afraid of breaking something there