Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cpu architecture and default environment in profiles envelope #2207

Merged
merged 3 commits into from Aug 5, 2022

Conversation

stefanosiano
Copy link
Member

📜 Description

Added cpu architecture in profiles envelope payload
Profiles environment defaults to "production"

💡 Motivation and Context

  • cpu architecture was requested to be added to the profiles data.
  • We found that profiles didn't have any environment, even if the transaction had one set. I figured out it was set in the transaction in the MainProcessor in case it's null, so i added the same logic to the profiles, too.

💚 How did you test it?

I added assertions on these fields to the ui test that sends a profile envelope

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

profiles environment defaults to "production"
profiles environment defaults to "production"
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@24d5c4f). Click here to learn what that means.
The diff coverage is 22.22%.

@@           Coverage Diff           @@
##             main    #2207   +/-   ##
=======================================
  Coverage        ?   80.87%           
  Complexity      ?     3343           
=======================================
  Files           ?      236           
  Lines           ?    12208           
  Branches        ?     1625           
=======================================
  Hits            ?     9873           
  Misses          ?     1735           
  Partials        ?      600           
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/ProfilingTraceData.java 76.38% <22.22%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stefanosiano stefanosiano merged commit fc6c136 into main Aug 5, 2022
@stefanosiano stefanosiano deleted the fix/profiles-envelope branch August 5, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants