Replace user other with data
#2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance metrics 馃殌
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7dc7e4 | 357.37 ms | 402.27 ms | 44.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7dc7e4 | 1.74 MiB | 2.33 MiB | 605.55 KiB |
Previous results on branch: feat/move-user-other-to-data
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7cd0ea5 | 274.55 ms | 320.37 ms | 45.82 ms |
| e790300 | 354.43 ms | 389.29 ms | 34.86 ms |
| 3225bfd | 297.04 ms | 358.67 ms | 61.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7cd0ea5 | 1.74 MiB | 2.33 MiB | 605.65 KiB |
| e790300 | 1.74 MiB | 2.33 MiB | 605.65 KiB |
| 3225bfd | 1.74 MiB | 2.33 MiB | 605.65 KiB |
philipphofmann
approved these changes
Sep 26, 2022
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "email": "c4d61c1b-c144-431e-868f-37a46be5e5f2", | |||
There was a problem hiding this comment.
Thanks for adding this 馃憦
| @@ -43,6 +43,15 @@ class UserSerializationTest { | |||
| assertEquals(expectedJson, actualJson) | |||
| } | |||
|
|
|||
| @Test | |||
| fun deserializeLegacy() { | |||
There was a problem hiding this comment.
馃憤 for adding a test for this.
| CollectionUtils.newConcurrentHashMap( | ||
| (Map<String, String>) reader.nextObjectOrNull()); | ||
| break; | ||
| case JsonKeys.OTHER: |
There was a problem hiding this comment.
l: Maybe a short comment on why we still have this?
marandaneto
reviewed
Sep 26, 2022
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### Features | |||
|
|
|||
| - Make user segment a top level property ([#2257](https://github.com/getsentry/sentry-java/pull/2257)) | |||
| - Make user segment a top level property ([#2258](https://github.com/getsentry/sentry-java/pull/2258)) | |||
There was a problem hiding this comment.
PR title and changelog seem to be off, this is not about the user.segment.
There was a problem hiding this comment.
Oh wow good catch thanks! Not sure how that happened. Guess I just rely on the auto generated title too much and in this case it used the title from the PR I want to merge into.
marandaneto
reviewed
Sep 26, 2022
| @@ -150,19 +150,43 @@ public void setIpAddress(final @Nullable String ipAddress) { | |||
| /** | |||
| * Gets other user related data. | |||
| * | |||
| * @deprecated use getData instead | |||
There was a problem hiding this comment.
You can use the @link javadocs
Eg {{@link SentryOptions#getShutdownTimeoutMillis()} }
marandaneto
reviewed
Sep 26, 2022
| @@ -43,6 +43,15 @@ class UserSerializationTest { | |||
| assertEquals(expectedJson, actualJson) | |||
| } | |||
|
|
|||
| @Test | |||
| fun deserializeLegacy() { | |||
There was a problem hiding this comment.
You can use backticks and call it deserialize legacy
adinauer
changed the title
other with data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
datais now used instead ofotheronUser. Can still parseotherfrom JSON but will move it todata.This way the custom properties will show up the same way in the UI as they do on other SDKs (e.g. JS).
馃挕 Motivation and Context
Closes #2242
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps