Merge hotfix 6.4.4 back into main #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb1d054.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
philipphofmann
approved these changes
Oct 10, 2022
@philipphofmann we can only do that once the release is merged back in here otherwise we'll have another failed release as we did last week ;-) |
…ipulation (#2282) * fix: frameMetricsAggregator calls may not get executed on main thread * fix: try/catch all FrameMetricsAggregator calls * Add FrameMetricsAggregator fixes to changelog * Add logging and main-thread tests to ActivityFramesTracker * Split up tests for FrameMetricsTracker * Update CHANGELOG.md Co-authored-by: Alexander Dinauer <adinauer@users.noreply.github.com> * Wrap main-thread / exception handling code in runSafelyOnUiThread method Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com>
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 54cebc8 | 331.12 ms | 385.14 ms | 54.02 ms |
| 2f079a1 | 296.91 ms | 337.43 ms | 40.51 ms |
| 4dd88fe | 302.12 ms | 331.17 ms | 29.04 ms |
| 1e4690d | 354.69 ms | 387.88 ms | 33.19 ms |
| 4dd88fe | 306.88 ms | 391.58 ms | 84.70 ms |
| 3d89dea | 345.59 ms | 364.06 ms | 18.47 ms |
| c5ccd8a | 329.98 ms | 365.52 ms | 35.54 ms |
| 7300956 | 324.20 ms | 353.79 ms | 29.58 ms |
| 7300956 | 337.57 ms | 384.21 ms | 46.64 ms |
| d4087ee | 278.00 ms | 313.86 ms | 35.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 54cebc8 | 1.73 MiB | 2.29 MiB | 579.43 KiB |
| 2f079a1 | 1.74 MiB | 2.33 MiB | 605.56 KiB |
| 4dd88fe | 1.73 MiB | 2.29 MiB | 579.50 KiB |
| 1e4690d | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 4dd88fe | 1.73 MiB | 2.29 MiB | 579.50 KiB |
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| c5ccd8a | 1.74 MiB | 2.33 MiB | 607.44 KiB |
| 7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
| 7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
| d4087ee | 1.73 MiB | 2.29 MiB | 579.50 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Fix for ConcurrentModificationException caused by manipulating
FrameMetricsAggregatorneeds to be merged intomainafter hotfixing6.4(#2282).