Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Remove verbose FrameMetricsAggregator failure logging #2293

Merged
merged 4 commits into from Oct 13, 2022

Conversation

markushi
Copy link
Member

📜 Description

Removes log output when calling the FrameMetricsAggregator fails.

💡 Motivation and Context

Right now any error when calling the FrameMetricsAggregator gets logged, including it's stacktrace. This can be confusing to the user, since we know FrameMetricsAggregator is expected to throw exceptions for various reasons.

Prior to 6.4.4 exceptions were swallowed, we should revert to that behavior.

Related issue: #2292

💚 How did you test it?

Ran tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 302.40 ms 349.60 ms 47.20 ms
Size 1.73 MiB 2.29 MiB 579.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d89dea 322.38 ms 350.82 ms 28.45 ms
7300956 324.20 ms 353.79 ms 29.58 ms
4ca1d7b 331.33 ms 335.78 ms 4.45 ms
4dd88fe 306.88 ms 391.58 ms 84.70 ms
7300956 337.57 ms 384.21 ms 46.64 ms
54cebc8 331.12 ms 385.14 ms 54.02 ms
c5ccd8a 329.98 ms 365.52 ms 35.54 ms
1e4690d 354.69 ms 387.88 ms 33.19 ms
d4087ee 278.00 ms 313.86 ms 35.86 ms
4dd88fe 302.12 ms 331.17 ms 29.04 ms

App size

Revision Plain With Sentry Diff
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
7300956 1.73 MiB 2.29 MiB 578.69 KiB
4ca1d7b 1.73 MiB 2.29 MiB 579.88 KiB
4dd88fe 1.73 MiB 2.29 MiB 579.50 KiB
7300956 1.73 MiB 2.29 MiB 578.69 KiB
54cebc8 1.73 MiB 2.29 MiB 579.43 KiB
c5ccd8a 1.74 MiB 2.33 MiB 607.44 KiB
1e4690d 1.74 MiB 2.33 MiB 604.92 KiB
d4087ee 1.73 MiB 2.29 MiB 579.50 KiB
4dd88fe 1.73 MiB 2.29 MiB 579.50 KiB

Previous results on branch: fix/framemetricsaggregator-logging

Startup times

Revision Plain With Sentry Diff
5216bcd 319.72 ms 364.58 ms 44.86 ms
2d19800 346.51 ms 387.73 ms 41.22 ms

App size

Revision Plain With Sentry Diff
5216bcd 1.73 MiB 2.29 MiB 579.71 KiB
2d19800 1.73 MiB 2.29 MiB 579.96 KiB

@markushi markushi merged commit 2be62a1 into main Oct 13, 2022
@markushi markushi deleted the fix/framemetricsaggregator-logging branch October 13, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry: Failed to execute FrameMetricsAggregator.remove
3 participants