-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release branch for pre-releasing 6.7
#2307
Conversation
This reverts commit cbf6abf.
Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com> Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
Previous results on branch: feat/6.7.x
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d55e277 | 310.20 ms | 329.74 ms | 19.54 ms |
843d929 | 341.48 ms | 378.30 ms | 36.82 ms |
3e6c9e5 | 297.19 ms | 340.93 ms | 43.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d55e277 | 1.73 MiB | 2.32 MiB | 608.49 KiB |
843d929 | 1.73 MiB | 2.32 MiB | 607.06 KiB |
3e6c9e5 | 1.73 MiB | 2.32 MiB | 608.49 KiB |
@Override | ||
@SuppressWarnings("lgtm[java/spring-disabled-csrf-protection]") | ||
protected void configure(final @NotNull HttpSecurity http) throws Exception { | ||
http.csrf().disable().authorizeRequests().anyRequest().authenticated().and().httpBasic(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
@Override | ||
@SuppressWarnings("lgtm[java/spring-disabled-csrf-protection]") | ||
protected void configure(final @NotNull HttpSecurity http) throws Exception { | ||
http.csrf().disable().authorizeRequests().anyRequest().authenticated().and().httpBasic(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
Codecov ReportBase: 80.29% // Head: 80.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
============================================
+ Coverage 80.29% 80.36% +0.06%
- Complexity 3497 3670 +173
============================================
Files 250 290 +40
Lines 12969 13712 +743
Branches 1740 1801 +61
============================================
+ Hits 10414 11020 +606
- Misses 1897 2001 +104
- Partials 658 691 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good, since I reviewed it already, but the checks are failing
#skip-changelog
Merge when 6.7.0 becomes stable