-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added FrameMetrics to Android profiling data #2342
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c9c50a5
added ProfileMeasurements to AndroidTransactionProfiler and Profiling…
stefanosiano 1585c22
added ProfileMeasurements to AndroidTransactionProfiler and Profiling…
stefanosiano fed5b21
added ProfileMeasurements to AndroidTransactionProfiler and Profiling…
stefanosiano c5db530
added ProfileMeasurements to AndroidTransactionProfiler and Profiling…
stefanosiano 0da7bc2
updated espresso test dependency to run on Android 13 devices
stefanosiano d6fe562
frameMetrics collection anticipated to onActivityCreated instead of o…
stefanosiano 1db0628
updated tests
stefanosiano aad144f
We disable "Don't keep activities" developer option after receiving a…
stefanosiano f7c07ca
We disable "Don't keep activities" developer option after receiving a…
stefanosiano a8d1320
disabling "Don't keep activities" developer option programmatically d…
stefanosiano 3d70b80
Format code
getsentry-bot d3ea8ed
Merge branch 'main' into feat/profiling-frame-metrics
stefanosiano 5b906fa
updated changelog
stefanosiano 1807d69
Merge branch 'main' into feat/profiling-frame-metrics
stefanosiano 5bd9d16
measurements are not sent if empty
stefanosiano babdaa7
Merge branch 'main' into feat/profiling-frame-metrics
stefanosiano 0fa21e0
updated benchmark device from OnePlus Nord N200 to Google Pixel 3a
stefanosiano a50903c
Merge remote-tracking branch 'origin/feat/profiling-frame-metrics' in…
stefanosiano cafe0f3
added finals everywhere
stefanosiano ace3c67
Remove profiler main thread io (#2348)
stefanosiano 6f80fc1
Merge branch 'main' into feat/profiling-frame-metrics
stefanosiano 80a206d
updated test dependencies to stable versions
stefanosiano c2599c1
SentryFrameMetricsCollector start collecting frameMetrics in onActivi…
stefanosiano b771ce1
Merge branch 'main' into feat/profiling-frame-metrics
stefanosiano e606515
increased benchmark cpu overhead threshold from 5% to 5.5%
stefanosiano a4e8237
Merge branch 'main' into feat/profiling-frame-metrics
stefanosiano bf05cd0
updated changelog
stefanosiano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, we should probably also switch over in the ActivityFramesTracker, because for now we're just using hardcoded 16ms for detecting slow frames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this PR of course :)