Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't sent device name if DefaultPII is disabled #2354

Merged
merged 1 commit into from Nov 14, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 11, 2022

📜 Description

💡 Motivation and Context

closes #2063

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 353.90 ms 375.67 ms 21.77 ms
Size 1.73 MiB 2.32 MiB 609.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f809aac 301.51 ms 346.60 ms 45.09 ms
a04f788 321.78 ms 354.12 ms 32.35 ms
7597ded 289.60 ms 339.69 ms 50.09 ms
90e9745 314.68 ms 357.28 ms 42.60 ms
38e4f11 358.20 ms 433.73 ms 75.53 ms

App size

Revision Plain With Sentry Diff
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
a04f788 1.73 MiB 2.32 MiB 609.88 KiB
7597ded 1.73 MiB 2.32 MiB 609.88 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB
38e4f11 1.73 MiB 2.32 MiB 609.82 KiB

Previous results on branch: fix/skip-device-name

Startup times

Revision Plain With Sentry Diff
e7dc682 315.23 ms 352.18 ms 36.95 ms

App size

Revision Plain With Sentry Diff
e7dc682 1.73 MiB 2.32 MiB 609.88 KiB

@codecov-commenter
Copy link

Codecov Report

Base: 80.36% // Head: 80.36% // No change to project coverage 👍

Coverage data is based on head (1035e1c) compared to base (51e7326).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2354   +/-   ##
=========================================
  Coverage     80.36%   80.36%           
  Complexity     3670     3670           
=========================================
  Files           290      290           
  Lines         13712    13712           
  Branches       1801     1801           
=========================================
  Hits          11020    11020           
  Misses         2001     2001           
  Partials        691      691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems flipped. Could you please also add an entry to the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultAndroidEventProcessor#getDevice should not set getDeviceName if sendDefaultPii isn't enabled
4 participants