Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ANR on dropped uncaught exception events #2368

Merged
merged 3 commits into from Nov 16, 2022
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 16, 2022

馃摐 Description

We were trying to flush the event to disk, even though the event was dropped and we never called markFlushed, hence it was blocking for 15seconds everytime the event is dropped 馃檲

馃挕 Motivation and Context

Closes #2346

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 354.80 ms 392.86 ms 38.06 ms
Size 1.73 MiB 2.32 MiB 610.02 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f809aac 301.51 ms 346.60 ms 45.09 ms
a04f788 321.78 ms 354.12 ms 32.35 ms
38e4f11 358.20 ms 433.73 ms 75.53 ms
507f924 342.51 ms 402.65 ms 60.14 ms
90e9745 314.68 ms 357.28 ms 42.60 ms
7597ded 289.60 ms 339.69 ms 50.09 ms

App size

Revision Plain With Sentry Diff
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
a04f788 1.73 MiB 2.32 MiB 609.88 KiB
38e4f11 1.73 MiB 2.32 MiB 609.82 KiB
507f924 1.73 MiB 2.32 MiB 609.95 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB
7597ded 1.73 MiB 2.32 MiB 609.88 KiB

@markushi markushi merged commit 15bb186 into main Nov 16, 2022
@markushi markushi deleted the fix/anr-dropped-events branch November 16, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANR before crash when SentryOptions.BeforeSendCallback returns null
2 participants