Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set transactionNameSource to CUSTOM when setting transaction name #2405

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 1, 2022

馃摐 Description

Set source to CUSTOM when setting transaction name without source

馃挕 Motivation and Context

Transaction name could be set by user and previously set source would be kept.

馃挌 How did you test it?

Unit Test

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@adinauer adinauer changed the title Set source to CUSTOM when setting transaction name Set transactionNameSource to CUSTOM when setting transaction name Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 353.79 ms 378.26 ms 24.47 ms
Size 1.73 MiB 2.32 MiB 612.47 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f809aac 301.51 ms 346.60 ms 45.09 ms
81a1a6c 328.73 ms 421.28 ms 92.55 ms
4a9c176 319.77 ms 363.20 ms 43.43 ms
3695453 299.25 ms 360.04 ms 60.79 ms
7967d22 289.28 ms 377.11 ms 87.83 ms
507f924 342.51 ms 402.65 ms 60.14 ms
4a9c176 336.33 ms 384.73 ms 48.41 ms
3695453 314.63 ms 353.10 ms 38.47 ms
38e4f11 358.20 ms 433.73 ms 75.53 ms
16371c5 314.02 ms 394.54 ms 80.52 ms

App size

Revision Plain With Sentry Diff
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
81a1a6c 1.73 MiB 2.32 MiB 612.47 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
7967d22 1.73 MiB 2.32 MiB 612.47 KiB
507f924 1.73 MiB 2.32 MiB 609.95 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
38e4f11 1.73 MiB 2.32 MiB 609.82 KiB
16371c5 1.73 MiB 2.32 MiB 611.62 KiB

}

this.name = name;
setName(name, TransactionNameSource.CUSTOM);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we call this method internally?
If we do, we cannot overwrite to custom, only if the user does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point will check. But if so we could simply change our code to use the other overload.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any direct calls to this overload (outside of tests).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check cross platform SDKs before merging this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marandaneto should we check any SDKs first or can I go ahead and merge this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit 0c7bed9 into main Jan 10, 2023
@adinauer adinauer deleted the fix/set-source-when-setting-transaction-name branch January 10, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants