Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace java.util.Objects with io.sentry.util.Objects #2436

Merged
merged 2 commits into from Dec 19, 2022
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 19, 2022

馃摐 Description

Since our minSdk is 16 (14 in fact, but nobody is using that already), we cannot use java.util.Objects because it's available only from API 19.

馃挕 Motivation and Context

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 390.62 ms 412.56 ms 21.94 ms
Size 1.73 MiB 2.33 MiB 615.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f1150bc 355.71 ms 369.74 ms 14.03 ms
f809aac 301.51 ms 346.60 ms 45.09 ms
703d523 330.27 ms 377.66 ms 47.39 ms
703d523 358.00 ms 369.94 ms 11.94 ms
4a9c176 336.33 ms 384.73 ms 48.41 ms
31f3e4c 325.22 ms 342.77 ms 17.55 ms
81a1a6c 328.73 ms 421.28 ms 92.55 ms
7967d22 289.28 ms 377.11 ms 87.83 ms
4a9c176 320.62 ms 334.68 ms 14.06 ms
38e4f11 358.20 ms 433.73 ms 75.53 ms

App size

Revision Plain With Sentry Diff
f1150bc 1.73 MiB 2.33 MiB 615.66 KiB
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
703d523 1.73 MiB 2.33 MiB 613.23 KiB
703d523 1.73 MiB 2.33 MiB 613.23 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
31f3e4c 1.73 MiB 2.32 MiB 612.47 KiB
81a1a6c 1.73 MiB 2.32 MiB 612.47 KiB
7967d22 1.73 MiB 2.32 MiB 612.47 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
38e4f11 1.73 MiB 2.32 MiB 609.82 KiB

Previous results on branch: fix/objects-api-19

Startup times

Revision Plain With Sentry Diff
8a151f4 348.64 ms 392.76 ms 44.12 ms
1cfc50f 387.96 ms 452.46 ms 64.50 ms

App size

Revision Plain With Sentry Diff
8a151f4 1.73 MiB 2.33 MiB 615.83 KiB
1cfc50f 1.73 MiB 2.33 MiB 615.83 KiB

@romtsn romtsn enabled auto-merge (squash) December 19, 2022 09:28
@romtsn romtsn merged commit ad3465a into main Dec 19, 2022
@romtsn romtsn deleted the fix/objects-api-19 branch December 19, 2022 09:28
@github-actions
Copy link
Contributor

Fails
馃毇 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Replace java.util.Objects with io.sentry.util.Objects ([#2436](https://github.com/getsentry/sentry-java/pull/2436))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 馃毇 dangerJS against 615c02b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants