Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gh workflow for testing release builds against AGP matrix #2439

Merged
merged 9 commits into from Dec 28, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 21, 2022

#skip-changelog

  • Adds a new test project, which contains different dependencies (or does not) to test our runtime checks against r8 behavior
  • Adds AGP compat matrix to test forwards compatibility with AGP

Closes #2093

@romtsn romtsn marked this pull request as draft December 21, 2022 16:16
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c91ac0e

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 318.88 ms 380.33 ms 61.45 ms
Size 1.73 MiB 2.33 MiB 616.45 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f1150bc 306.15 ms 306.58 ms 0.44 ms
4a9c176 320.62 ms 334.68 ms 14.06 ms
81a1a6c 294.04 ms 341.19 ms 47.15 ms
3695453 299.25 ms 360.04 ms 60.79 ms
7967d22 289.28 ms 377.11 ms 87.83 ms
5fd37fa 313.08 ms 357.84 ms 44.76 ms
f1150bc 352.62 ms 453.27 ms 100.65 ms
31f3e4c 325.22 ms 342.77 ms 17.55 ms
ad3465a 424.31 ms 472.21 ms 47.90 ms
1e1ab7f 383.48 ms 441.37 ms 57.89 ms

App size

Revision Plain With Sentry Diff
f1150bc 1.73 MiB 2.33 MiB 615.66 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
81a1a6c 1.73 MiB 2.32 MiB 612.47 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
7967d22 1.73 MiB 2.32 MiB 612.47 KiB
5fd37fa 1.73 MiB 2.33 MiB 616.48 KiB
f1150bc 1.73 MiB 2.33 MiB 615.66 KiB
31f3e4c 1.73 MiB 2.32 MiB 612.47 KiB
ad3465a 1.73 MiB 2.33 MiB 615.83 KiB
1e1ab7f 1.73 MiB 2.32 MiB 612.36 KiB

Previous results on branch: feat/agp-ci-matrix

Startup times

Revision Plain With Sentry Diff
1c74a11 323.06 ms 370.80 ms 47.73 ms
ed07d21 306.88 ms 349.02 ms 42.15 ms
7ed1a2d 331.66 ms 423.71 ms 92.05 ms
2233c79 306.56 ms 365.53 ms 58.97 ms
632fb04 299.88 ms 402.33 ms 102.45 ms
5b9a46e 352.90 ms 369.16 ms 16.27 ms

App size

Revision Plain With Sentry Diff
1c74a11 1.73 MiB 2.33 MiB 615.83 KiB
ed07d21 1.73 MiB 2.33 MiB 615.83 KiB
7ed1a2d 1.73 MiB 2.33 MiB 615.83 KiB
2233c79 1.73 MiB 2.33 MiB 615.83 KiB
632fb04 1.73 MiB 2.33 MiB 615.83 KiB
5b9a46e 1.73 MiB 2.33 MiB 616.45 KiB

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Base: 80.09% // Head: 80.09% // No change to project coverage 👍

Coverage data is based on head (c91ac0e) compared to base (5fd37fa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2439   +/-   ##
=========================================
  Coverage     80.09%   80.09%           
  Complexity     3807     3807           
=========================================
  Files           306      306           
  Lines         14390    14390           
  Branches       1904     1904           
=========================================
  Hits          11525    11525           
  Misses         2118     2118           
  Partials        747      747           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn marked this pull request as ready for review December 23, 2022 23:36
@romtsn romtsn merged commit b3704c8 into main Dec 28, 2022
@romtsn romtsn deleted the feat/agp-ci-matrix branch December 28, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build sample app against AGP matrix on CI
4 participants