Add traceOptionsRequests option to disable tracing of OPTIONS requests
#2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
adinauer
commented
Jan 5, 2023
| @@ -387,6 +387,10 @@ public class SentryOptions { | |||
|
|
|||
| private @NotNull IMemoryCollector memoryCollector = NoOpMemoryCollector.getInstance(); | |||
|
|
|||
| // TODO this should default to false on the next major | |||
There was a problem hiding this comment.
Do you agree with this approach of having it default to true until the next major then change it to the desired default of false?
|
|
Docs PR here: getsentry/sentry-docs#6019 |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4a9c176 | 320.62 ms | 334.68 ms | 14.06 ms |
| a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
| f1150bc | 306.15 ms | 306.58 ms | 0.44 ms |
| d00c464 | 337.43 ms | 387.57 ms | 50.15 ms |
| f55020d | 338.00 ms | 370.74 ms | 32.74 ms |
| 4a9c176 | 319.77 ms | 363.20 ms | 43.43 ms |
| 703d523 | 275.51 ms | 323.02 ms | 47.51 ms |
| ecf9680 | 321.55 ms | 385.52 ms | 63.97 ms |
| b85d8aa | 289.35 ms | 335.92 ms | 46.56 ms |
| 90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
| a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| f1150bc | 1.73 MiB | 2.33 MiB | 615.66 KiB |
| d00c464 | 1.73 MiB | 2.33 MiB | 613.02 KiB |
| f55020d | 1.73 MiB | 2.33 MiB | 616.54 KiB |
| 4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
| 703d523 | 1.73 MiB | 2.33 MiB | 613.23 KiB |
| ecf9680 | 1.73 MiB | 2.32 MiB | 612.39 KiB |
| b85d8aa | 1.73 MiB | 2.32 MiB | 611.62 KiB |
| 90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
Codecov ReportBase: 80.15% // Head: 80.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2453 +/- ##
============================================
- Coverage 80.15% 80.14% -0.02%
- Complexity 3828 3836 +8
============================================
Files 310 310
Lines 14466 14473 +7
Branches 1914 1915 +1
============================================
+ Hits 11595 11599 +4
- Misses 2121 2124 +3
Partials 750 750
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markushi
approved these changes
Jan 5, 2023
| @@ -387,6 +387,10 @@ public class SentryOptions { | |||
|
|
|||
| private @NotNull IMemoryCollector memoryCollector = NoOpMemoryCollector.getInstance(); | |||
|
|
|||
| // TODO this should default to false on the next major | |||
romtsn
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
traceOptionsRequestsdefaults totruefor now. I think we should change this tofalseonly in the next major release.💡 Motivation and Context
Allows us to fix #2231 in the next major by flipping the default to
false.💚 How did you test it?
Unit Tests, manually
📝 Checklist
🔮 Next steps