Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamps of PerformanceCollectionData in profiles #2632

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

PerformanceCollectionData timestamps in profiles have been adjusted to be relative to the profile start

💡 Motivation and Context

PerformanceCollectionData timestamps were absolute values, but they were supposed to be relative to the profile start

💚 How did you test it?

Added a Ui test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 310.06 ms 319.74 ms 9.68 ms
Size 1.73 MiB 2.26 MiB 551.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d81684e 235.73 ms 328.76 ms 93.03 ms
33c80c7 318.88 ms 348.14 ms 29.26 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
33c80c7 331.94 ms 370.54 ms 38.60 ms

App size

Revision Plain With Sentry Diff
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: fix/perfomance-data-timestamps-profiles

Startup times

Revision Plain With Sentry Diff
d8599b0 352.98 ms 401.02 ms 48.04 ms
f8f2181 295.63 ms 358.49 ms 62.86 ms

App size

Revision Plain With Sentry Diff
d8599b0 1.73 MiB 2.26 MiB 551.12 KiB
f8f2181 1.73 MiB 2.26 MiB 551.12 KiB

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6af3746) 81.37% compared to head (17d2ff1) 81.37%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2632   +/-   ##
=========================================
  Coverage     81.37%   81.37%           
- Complexity     4221     4222    +1     
=========================================
  Files           337      337           
  Lines         15601    15602    +1     
  Branches       2037     2037           
=========================================
+ Hits          12695    12696    +1     
  Misses         2111     2111           
  Partials        795      795           
Impacted Files Coverage Δ
...y/profilemeasurements/ProfileMeasurementValue.java 61.22% <100.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano marked this pull request as ready for review March 30, 2023 11:35
@stefanosiano stefanosiano merged commit b6c2161 into main Apr 4, 2023
18 checks passed
@stefanosiano stefanosiano deleted the fix/perfomance-data-timestamps-profiles branch April 4, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants