Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log4j2 integration compatible with log4j 3.0 #2634

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Mar 31, 2023

📜 Description

Bump log4j2 version to 2.20.0
Use AnnotationProcessor instead of package scanning to find Plugin.

💡 Motivation and Context

Fixes #2616

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against df15aba

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (de453e7) 81.39% compared to head (df15aba) 81.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2634   +/-   ##
=========================================
  Coverage     81.39%   81.39%           
  Complexity     4231     4231           
=========================================
  Files           337      337           
  Lines         15622    15622           
  Branches       2041     2041           
=========================================
  Hits          12715    12715           
  Misses         2112     2112           
  Partials        795      795           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
lbloder and others added 2 commits April 4, 2023 21:04
Co-authored-by: Alexander Dinauer <adinauer@users.noreply.github.com>
# Conflicts:
#	CHANGELOG.md
@lbloder lbloder marked this pull request as ready for review April 4, 2023 19:07
@lbloder lbloder merged commit 4337591 into main Apr 4, 2023
17 checks passed
@lbloder lbloder deleted the feat/log4j2_3 branch April 4, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Log4j2 3.x
2 participants