Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing propagateMinConstraints flag for SentryTraced #2637

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

markushi
Copy link
Member

@markushi markushi commented Apr 3, 2023

📜 Description

Our SentryTraced wrapper is using a Box right now to capture composition time. We should set the propagateMinConstraints = true flag to ensure SentryTraced is not modifying any layouting behavior.

💡 Motivation and Context

As commented here: 1d79c71#r105548701

💚 How did you test it?

Manual

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

markushi referenced this pull request Apr 3, 2023
…2507)

Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 389.52 ms 439.57 ms 50.05 ms
Size 1.73 MiB 2.26 MiB 551.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d81684e 235.73 ms 328.76 ms 93.03 ms
33c80c7 318.88 ms 348.14 ms 29.26 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
33c80c7 331.94 ms 370.54 ms 38.60 ms

App size

Revision Plain With Sentry Diff
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33c80c7) 81.37% compared to head (52564a8) 81.37%.

❗ Current head 52564a8 differs from pull request most recent head 1c080b6. Consider uploading reports for the commit 1c080b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2637   +/-   ##
=========================================
  Coverage     81.37%   81.37%           
  Complexity     4221     4221           
=========================================
  Files           337      337           
  Lines         15601    15601           
  Branches       2037     2037           
=========================================
  Hits          12695    12695           
  Misses         2111     2111           
  Partials        795      795           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@markushi markushi merged commit 6af3746 into main Apr 3, 2023
16 checks passed
@markushi markushi deleted the fix/compose-propagate-constraints branch April 3, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants