-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aar artifacts publication for Maven #2641
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
============================================
+ Coverage 81.25% 81.39% +0.13%
+ Complexity 4259 4231 -28
============================================
Files 337 337
Lines 15741 15622 -119
Branches 2079 2041 -38
============================================
- Hits 12790 12715 -75
+ Misses 2130 2112 -18
+ Partials 821 795 -26 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions otherwise LGTM.
📜 Description
Gradle has a bug gradle/gradle#3170, where they don't assign the
aar
artifact type to android libraries, so Maven (the build system) cannot automatically infer the correct type, hence our artifacts cannot even be downloaded, when using Maven instead of Gradle.We're just working it around by modifying the pom.xml file.
The workaround is slightly adapted from https://github.com/androidx/androidx/blob/c799cba927a71f01ea6b421a8f83c181682633fb/buildSrc/private/src/main/kotlin/androidx/build/MavenUploadHelper.kt#L524-L549
💡 Motivation and Context
Closes #1947
💚 How did you test it?
Manually published to maven local
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps