Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aar artifacts publication for Maven #2641

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 6, 2023

📜 Description

Gradle has a bug gradle/gradle#3170, where they don't assign the aar artifact type to android libraries, so Maven (the build system) cannot automatically infer the correct type, hence our artifacts cannot even be downloaded, when using Maven instead of Gradle.

We're just working it around by modifying the pom.xml file.

The workaround is slightly adapted from https://github.com/androidx/androidx/blob/c799cba927a71f01ea6b421a8f83c181682633fb/buildSrc/private/src/main/kotlin/androidx/build/MavenUploadHelper.kt#L524-L549

💡 Motivation and Context

Closes #1947

💚 How did you test it?

Manually published to maven local
image

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (4d04310) 81.25% compared to head (0206ad2) 81.39%.

❗ Current head 0206ad2 differs from pull request most recent head 62d5b6c. Consider uploading reports for the commit 62d5b6c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2641      +/-   ##
============================================
+ Coverage     81.25%   81.39%   +0.13%     
+ Complexity     4259     4231      -28     
============================================
  Files           337      337              
  Lines         15741    15622     -119     
  Branches       2079     2041      -38     
============================================
- Hits          12790    12715      -75     
+ Misses         2130     2112      -18     
+ Partials        821      795      -26     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions otherwise LGTM.

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@romtsn romtsn enabled auto-merge (squash) April 21, 2023 13:04
@romtsn romtsn disabled auto-merge April 21, 2023 13:57
@romtsn romtsn marked this pull request as draft April 21, 2023 13:57
@romtsn romtsn marked this pull request as ready for review April 21, 2023 13:57
@romtsn romtsn enabled auto-merge (squash) April 21, 2023 13:59
@romtsn romtsn merged commit e9e1695 into main Apr 21, 2023
5 of 12 checks passed
@romtsn romtsn deleted the fix/rz/android-artifacts-publication-for-maven branch April 21, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Android missing Maven dependencies
3 participants