Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp intervals of PerformanceCollectionData in profiles #2648

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Apr 11, 2023

📜 Description

fixed timestamps of PerformanceCollectionData in profiles
updated ui test to cover all measurements cases

💡 Motivation and Context

The PerformanceCollectionData measurements in the profiles were not converted to nanoseconds, generating problems with their intervals

💚 How did you test it?

Updated ui test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

updated ui test to cover all measurements cases
updated ui test to cover all measurements cases
@stefanosiano stefanosiano changed the title Fix timestamps of PerformanceCollectionData in profiles Fix timestamp intervals of PerformanceCollectionData in profiles Apr 11, 2023
@stefanosiano stefanosiano marked this pull request as ready for review April 11, 2023 18:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 263.07 ms 349.22 ms 86.15 ms
Size 1.73 MiB 2.26 MiB 550.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
33c80c7 318.88 ms 348.14 ms 29.26 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
d81684e 235.73 ms 328.76 ms 93.03 ms
33c80c7 331.94 ms 370.54 ms 38.60 ms

App size

Revision Plain With Sentry Diff
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: fix/profiles-collection-data-timestamps

Startup times

Revision Plain With Sentry Diff
52c84b1 293.48 ms 376.13 ms 82.65 ms

App size

Revision Plain With Sentry Diff
52c84b1 1.73 MiB 2.26 MiB 550.19 KiB

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (18efe20) 81.39% compared to head (f921c4a) 81.39%.

❗ Current head f921c4a differs from pull request most recent head b4f7a3c. Consider uploading reports for the commit b4f7a3c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2648   +/-   ##
=========================================
  Coverage     81.39%   81.39%           
  Complexity     4227     4227           
=========================================
  Files           337      337           
  Lines         15622    15622           
  Branches       2039     2039           
=========================================
  Hits          12715    12715           
  Misses         2112     2112           
  Partials        795      795           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

updated ui test to cover all measurements cases
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@stefanosiano stefanosiano merged commit 0686640 into main Apr 12, 2023
15 checks passed
@stefanosiano stefanosiano deleted the fix/profiles-collection-data-timestamps branch April 12, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants