Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track a ttfd span per Activity #2673

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Track a ttfd span per Activity #2673

merged 5 commits into from
Apr 28, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

Added map of ttfd spans in ActivityLifecycleIntegration, to automatically stop only the correct one.

💡 Motivation and Context

Due to Activity lifecycle, during a navigation between two activities, when the previous activity was destroyed the ActivityLifecycleIntegration was terminating the ttfd span of the new activity.

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 339.85 ms 379.02 ms 39.17 ms
Size 1.72 MiB 2.26 MiB 552.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
33c80c7 331.94 ms 370.54 ms 38.60 ms
d81684e 235.73 ms 328.76 ms 93.03 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
33c80c7 318.88 ms 348.14 ms 29.26 ms

App size

Revision Plain With Sentry Diff
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: fix/multiple-ttfd-spans

Startup times

Revision Plain With Sentry Diff
29e508d 284.39 ms 343.41 ms 59.02 ms

App size

Revision Plain With Sentry Diff
29e508d 1.73 MiB 2.26 MiB 550.67 KiB

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (308cdb2) 81.28% compared to head (fd3be52) 81.28%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2673   +/-   ##
=========================================
  Coverage     81.28%   81.28%           
  Complexity     4263     4263           
=========================================
  Files           337      337           
  Lines         15759    15759           
  Branches       2080     2080           
=========================================
  Hits          12810    12810           
  Misses         2128     2128           
  Partials        821      821           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano marked this pull request as ready for review April 24, 2023 12:59
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@stefanosiano stefanosiano merged commit 544da32 into main Apr 28, 2023
18 checks passed
@stefanosiano stefanosiano deleted the fix/multiple-ttfd-spans branch April 28, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants