Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add screenshot and view hierarchy to integration list #2698

Merged
merged 6 commits into from
May 5, 2023

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented May 4, 2023

📜 Description

Add ViewHierarchy and Screenshot Event processors to integration list

Notes

Enabling/Disabling the EventProcessors using the SentryAndroidOptions at runtime i.e. after Sentry.init was called will not change the integration list

💡 Motivation and Context

Fixes #2644

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 29b977c

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 334.16 ms 374.00 ms 39.84 ms
Size 1.72 MiB 2.26 MiB 553.67 KiB

Previous results on branch: feat/new_integratons_to_list

Startup times

Revision Plain With Sentry Diff
abc9c6d 331.49 ms 346.96 ms 15.47 ms

App size

Revision Plain With Sentry Diff
abc9c6d 1.72 MiB 2.26 MiB 553.65 KiB

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b03d10f) 81.32% compared to head (29b977c) 81.32%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2698   +/-   ##
=========================================
  Coverage     81.32%   81.32%           
  Complexity     4271     4271           
=========================================
  Files           337      337           
  Lines         15795    15796    +1     
  Branches       2083     2083           
=========================================
+ Hits          12845    12846    +1     
  Misses         2127     2127           
  Partials        823      823           
Impacted Files Coverage Δ
...entry/src/main/java/io/sentry/IntegrationName.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the naming comment. Thanks Lukas!

@lbloder lbloder marked this pull request as ready for review May 5, 2023 07:52
@lbloder lbloder merged commit 59a452f into main May 5, 2023
19 checks passed
@lbloder lbloder deleted the feat/new_integratons_to_list branch May 5, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Screenshot and ViewHierarchy to integrations list
2 participants