Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode/Decode internal apollo3 headers #2707

Merged
merged 7 commits into from
May 19, 2023
Merged

Encode/Decode internal apollo3 headers #2707

merged 7 commits into from
May 19, 2023

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented May 11, 2023

📜 Description

Base64 encode/decode internal apollo3 headers

💡 Motivation and Context

Fixes #2680

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 296.14 ms 309.60 ms 13.46 ms
Size 1.72 MiB 2.28 MiB 570.45 KiB

Previous results on branch: fix/apollo-3-header

Startup times

Revision Plain With Sentry Diff
d9bd3b7 314.76 ms 355.60 ms 40.84 ms
3ecfb25 301.62 ms 368.38 ms 66.76 ms
bccb1ad 314.51 ms 380.98 ms 66.47 ms

App size

Revision Plain With Sentry Diff
d9bd3b7 1.72 MiB 2.28 MiB 565.45 KiB
3ecfb25 1.72 MiB 2.28 MiB 570.00 KiB
bccb1ad 1.72 MiB 2.28 MiB 570.00 KiB

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.01 ⚠️

Comparison is base (e9bec6e) 81.11% compared to head (84d12b0) 81.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2707      +/-   ##
============================================
- Coverage     81.11%   81.11%   -0.01%     
- Complexity     4445     4447       +2     
============================================
  Files           345      345              
  Lines         16387    16394       +7     
  Branches       2226     2226              
============================================
+ Hits          13293    13298       +5     
- Misses         2166     2168       +2     
  Partials        928      928              
Impacted Files Coverage Δ
.../io/sentry/apollo3/SentryApollo3HttpInterceptor.kt 81.18% <80.00%> (-0.73%) ⬇️
...java/io/sentry/apollo3/SentryApollo3Interceptor.kt 64.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbloder lbloder changed the title add test for non-ascii characters as id Encode/Decode internal apollo3 headers May 11, 2023
@lbloder lbloder marked this pull request as ready for review May 11, 2023 13:26
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I think we should should handle decode exceptions directly in code, not sure Apollo fails the request if we throw out.

@lbloder lbloder merged commit b6b3a90 into main May 19, 2023
19 of 20 checks passed
@lbloder lbloder deleted the fix/apollo-3-header branch May 19, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected char 0xe1 at 7 in SENTRY-APOLLO-3-VARIABLES value: {name=á}
2 participants