Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish WebFlux transaction before popping scope #2724

Merged
merged 4 commits into from
May 30, 2023

Merge branch 'main' into fix/finish-webflux-transaction-before-scope-pop

d832b5b
Select commit
Loading
Failed to load commit list.
Merged

Finish WebFlux transaction before popping scope #2724

Merge branch 'main' into fix/finish-webflux-transaction-before-scope-pop
d832b5b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 26, 2023 in 1s

78.04% of diff hit (target 81.13%)

View this Pull Request on Codecov

78.04% of diff hit (target 81.13%)

Annotations

Check warning on line 152 in sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/AbstractSentryWebFilter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/AbstractSentryWebFilter.java#L149-L152

Added lines #L149 - L152 were not covered by tests

Check warning on line 25 in sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java#L25

Added line #L25 was not covered by tests

Check warning on line 31 in sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java#L31

Added line #L31 was not covered by tests

Check warning on line 33 in sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java#L33

Added line #L33 was not covered by tests

Check warning on line 35 in sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java#L35

Added line #L35 was not covered by tests

Check warning on line 40 in sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilterWithThreadLocalAccessor.java#L39-L40

Added lines #L39 - L40 were not covered by tests

Check warning on line 138 in sentry-spring/src/main/java/io/sentry/spring/webflux/SentryWebFilter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

sentry-spring/src/main/java/io/sentry/spring/webflux/SentryWebFilter.java#L135-L138

Added lines #L135 - L138 were not covered by tests