Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load sentry-debug-meta.properties #2734

Merged
merged 6 commits into from
May 30, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented May 25, 2023

📜 Description

We now also load sentry-debug-meta.properties for Java (not just Android). This means source bundle IDs are now loaded at runtime and sent to Sentry to enable source context.

💡 Motivation and Context

Source Context for Java (non Android)

💚 How did you test it?

Unit Tests, manually

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b0163a8

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 310.14 ms 340.56 ms 30.42 ms
Size 1.72 MiB 2.28 MiB 571.51 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
16cd2b6 243.02 ms 349.69 ms 106.67 ms
46b1782 387.72 ms 458.74 ms 71.02 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
16cd2b6 1.72 MiB 2.28 MiB 570.95 KiB
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

Previous results on branch: feat/load-debug-meta-properties-for-non-android

Startup times

Revision Plain With Sentry Diff
042f7ad 331.06 ms 350.62 ms 19.56 ms
e284a1e 295.77 ms 319.94 ms 24.17 ms
8c386e8 367.82 ms 382.14 ms 14.32 ms

App size

Revision Plain With Sentry Diff
042f7ad 1.72 MiB 2.28 MiB 571.39 KiB
e284a1e 1.72 MiB 2.28 MiB 571.09 KiB
8c386e8 1.72 MiB 2.28 MiB 571.09 KiB

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 78.84% and project coverage change: -0.01 ⚠️

Comparison is base (a62c875) 81.10% compared to head (b0163a8) 81.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2734      +/-   ##
============================================
- Coverage     81.10%   81.09%   -0.01%     
- Complexity     4455     4470      +15     
============================================
  Files           344      347       +3     
  Lines         16420    16472      +52     
  Branches       2227     2232       +5     
============================================
+ Hits          13317    13358      +41     
- Misses         2174     2181       +7     
- Partials        929      933       +4     
Impacted Files Coverage Δ
...sentry/internal/debugmeta/NoOpDebugMetaLoader.java 66.66% <66.66%> (ø)
...y/internal/debugmeta/ResourcesDebugMetaLoader.java 73.68% <73.68%> (ø)
sentry/src/main/java/io/sentry/SentryOptions.java 79.95% <80.00%> (+<0.01%) ⬆️
...ava/io/sentry/util/DebugMetaPropertiesApplier.java 80.95% <80.95%> (ø)
sentry/src/main/java/io/sentry/Sentry.java 83.84% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, looking good! On Android it could make sense to lazy read the properties file, but since it wasn't done before either this could be a covered in future improvement ticket.

@adinauer adinauer merged commit 9dddfbf into main May 30, 2023
19 of 21 checks passed
@adinauer adinauer deleted the feat/load-debug-meta-properties-for-non-android branch May 30, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants