Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable RootChecker #2735

Merged
merged 3 commits into from
May 26, 2023
Merged

Add option to disable RootChecker #2735

merged 3 commits into from
May 26, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 25, 2023

📜 Description

Adds an option to disable RootChecker

💡 Motivation and Context

Closes #2718

💚 How did you test it?

Automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 302.14 ms 332.33 ms 30.19 ms
Size 1.72 MiB 2.28 MiB 570.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
46b1782 387.72 ms 458.74 ms 71.02 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

Previous results on branch: rz/feat/root-checker-option

Startup times

Revision Plain With Sentry Diff
a682c75 295.34 ms 307.00 ms 11.66 ms

App size

Revision Plain With Sentry Diff
a682c75 1.72 MiB 2.28 MiB 570.70 KiB

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (37cd75a) 81.11% compared to head (9b9d169) 81.13%.

❗ Current head 9b9d169 differs from pull request most recent head cd50df2. Consider uploading reports for the commit cd50df2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2735      +/-   ##
============================================
+ Coverage     81.11%   81.13%   +0.01%     
  Complexity     4449     4449              
============================================
  Files           345      345              
  Lines         16407    16402       -5     
  Branches       2226     2226              
============================================
- Hits          13308    13307       -1     
+ Misses         2172     2168       -4     
  Partials        927      927              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn enabled auto-merge (squash) May 26, 2023 09:47
@romtsn romtsn merged commit 3cb8080 into main May 26, 2023
16 of 17 checks passed
@romtsn romtsn deleted the rz/feat/root-checker-option branch May 26, 2023 09:49
@fzyzcjy
Copy link

fzyzcjy commented May 26, 2023

Thanks and looking forward to the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable RootChecker
3 participants