-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run AGP test matrix with/without sentry integrations #2743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 243.02 ms | 349.69 ms | 106.67 ms |
46b1782 | 387.72 ms | 458.74 ms | 71.02 ms |
1707044 | 338.80 ms | 384.79 ms | 46.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
46b1782 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
1707044 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
Previous results on branch: rz/fix/compose-hierarchy-r8-rule
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8702b51 | 328.76 ms | 344.18 ms | 15.42 ms |
66227da | 280.71 ms | 361.54 ms | 80.83 ms |
449a318 | 280.16 ms | 328.58 ms | 48.42 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8702b51 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
66227da | 1.72 MiB | 2.28 MiB | 570.95 KiB |
449a318 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
=========================================
Coverage 81.10% 81.10%
Complexity 4455 4455
=========================================
Files 344 344
Lines 16420 16420
Branches 2227 2227
=========================================
Hits 13317 13317
Misses 2174 2174
Partials 929 929 ☔ View full report in Codecov by Sentry. |
stefanosiano
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Fixes #2738
💚 How did you test it?
Manually and CI
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps