Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run AGP test matrix with/without sentry integrations #2743

Merged
merged 7 commits into from
May 30, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 29, 2023

📜 Description

  • Run AGP test matrix with/without sentry integrations to catch missing R8 rules
  • Add rule for ComposeViewHierarchyExporter

💡 Motivation and Context

Fixes #2738

💚 How did you test it?

Manually and CI

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 310.73 ms 321.94 ms 11.21 ms
Size 1.72 MiB 2.28 MiB 570.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
16cd2b6 243.02 ms 349.69 ms 106.67 ms
46b1782 387.72 ms 458.74 ms 71.02 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
16cd2b6 1.72 MiB 2.28 MiB 570.95 KiB
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

Previous results on branch: rz/fix/compose-hierarchy-r8-rule

Startup times

Revision Plain With Sentry Diff
8702b51 328.76 ms 344.18 ms 15.42 ms
66227da 280.71 ms 361.54 ms 80.83 ms
449a318 280.16 ms 328.58 ms 48.42 ms

App size

Revision Plain With Sentry Diff
8702b51 1.72 MiB 2.28 MiB 570.95 KiB
66227da 1.72 MiB 2.28 MiB 570.95 KiB
449a318 1.72 MiB 2.28 MiB 570.95 KiB

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a62c875) 81.10% compared to head (b3fb46c) 81.10%.

❗ Current head b3fb46c differs from pull request most recent head cf69615. Consider uploading reports for the commit cf69615 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2743   +/-   ##
=========================================
  Coverage     81.10%   81.10%           
  Complexity     4455     4455           
=========================================
  Files           344      344           
  Lines         16420    16420           
  Branches       2227     2227           
=========================================
  Hits          13317    13317           
  Misses         2174     2174           
  Partials        929      929           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn enabled auto-merge (squash) May 30, 2023 09:31
@romtsn romtsn merged commit b056859 into main May 30, 2023
18 checks passed
@romtsn romtsn deleted the rz/fix/compose-hierarchy-r8-rule branch May 30, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants