Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use String.join in Baggage as it requires API level 26 #2778

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jun 7, 2023

📜 Description

No longer use String.join in Baggage as it requires API level 26

💡 Motivation and Context

Fixes #2774

💚 How did you test it?

Unit Tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 321.66 ms 357.88 ms 36.22 ms
Size 1.72 MiB 2.28 MiB 571.64 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
46b1782 387.72 ms 458.74 ms 71.02 ms
16cd2b6 243.02 ms 349.69 ms 106.67 ms
cb6c658 327.57 ms 383.38 ms 55.80 ms
ff49977 325.84 ms 365.67 ms 39.83 ms
cb6c658 311.33 ms 355.09 ms 43.76 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
16cd2b6 1.72 MiB 2.28 MiB 570.95 KiB
cb6c658 1.72 MiB 2.28 MiB 571.59 KiB
ff49977 1.72 MiB 2.28 MiB 571.59 KiB
cb6c658 1.72 MiB 2.28 MiB 571.59 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (afecabf) 81.10% compared to head (96230fc) 81.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2778      +/-   ##
============================================
+ Coverage     81.10%   81.11%   +0.01%     
- Complexity     4476     4479       +3     
============================================
  Files           347      347              
  Lines         16499    16510      +11     
  Branches       2236     2238       +2     
============================================
+ Hits          13381    13392      +11     
  Misses         2183     2183              
  Partials        935      935              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Baggage.java 86.62% <100.00%> (+0.23%) ⬆️
...ntry/src/main/java/io/sentry/util/StringUtils.java 87.75% <100.00%> (+2.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer merged commit 34716f3 into main Jun 7, 2023
25 of 27 checks passed
@adinauer adinauer deleted the fix/string-join-android-compatibility branch June 7, 2023 09:25
@marandaneto
Copy link
Contributor

@romtsn @kahest can you prioritize #1403 ? this keeps happening so it should not be p2.
If this does not solve the issue because linting goes thru and the build also passes, we can run our tests on the min API, using RobolectricTestRunner and emulateSdk at least.

@kahest
Copy link
Member

kahest commented Jun 7, 2023

@marandaneto makes sense, we'll discuss in sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants