Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enableNdk to SentryAndroidOptions #2793

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

markushi
Copy link
Member

📜 Description

This is a breaking change due to binary incompatibility.

💡 Motivation and Context

Fixes #1994

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c0b0727

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 270.57 ms 319.30 ms 48.73 ms
Size 1.72 MiB 2.28 MiB 572.21 KiB

Previous results on branch: feat/cleanup-sentry-options

Startup times

Revision Plain With Sentry Diff
4089ab0 319.57 ms 346.62 ms 27.05 ms
3bdeafc 288.54 ms 343.04 ms 54.50 ms
a6f4f04 321.35 ms 348.60 ms 27.25 ms
5a0c642 331.82 ms 372.81 ms 41.00 ms

App size

Revision Plain With Sentry Diff
4089ab0 1.72 MiB 2.28 MiB 572.21 KiB
3bdeafc 1.72 MiB 2.28 MiB 572.21 KiB
a6f4f04 1.72 MiB 2.28 MiB 572.21 KiB
5a0c642 1.72 MiB 2.28 MiB 572.21 KiB

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (9246ed4) 81.14% compared to head (c0b0727) 81.16%.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/7.0.0    #2793      +/-   ##
================================================
+ Coverage         81.14%   81.16%   +0.02%     
+ Complexity         4497     4496       -1     
================================================
  Files               348      348              
  Lines             16677    16670       -7     
  Branches           2267     2267              
================================================
- Hits              13532    13530       -2     
+ Misses             2198     2193       -5     
  Partials            947      947              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryOptions.java 80.70% <ø> (+0.74%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@markushi markushi changed the base branch from main to feat/7.0.0 June 22, 2023 05:49
@markushi markushi merged commit 0566579 into feat/7.0.0 Jun 29, 2023
17 checks passed
@markushi markushi deleted the feat/cleanup-sentry-options branch June 29, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Android options from SentryOptions to SentryAndroidOptions
2 participants