Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env from SentryOptions if none persisted in ANRv2 #2809

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 30, 2023

📜 Description

Use env from SentryOptions if none persisted in ANRv2

💡 Motivation and Context

Internal feedback

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 288.23 ms 336.92 ms 48.69 ms
Size 1.72 MiB 2.29 MiB 574.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
dc67004 273.86 ms 346.37 ms 72.51 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
0310da5 381.20 ms 404.50 ms 23.30 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms

App size

Revision Plain With Sentry Diff
dc67004 1.72 MiB 2.28 MiB 573.45 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
0310da5 1.72 MiB 2.28 MiB 573.45 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (675fc87) 81.25% compared to head (d437909) 81.25%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2809   +/-   ##
=========================================
  Coverage     81.25%   81.25%           
  Complexity     4560     4560           
=========================================
  Files           350      350           
  Lines         16870    16870           
  Branches       2274     2274           
=========================================
  Hits          13708    13708           
  Misses         2219     2219           
  Partials        943      943           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn merged commit c03a05e into main Jun 30, 2023
21 checks passed
@romtsn romtsn deleted the rz/enh/anr-v2-env branch June 30, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants