Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow/frozen frames were not reported with transactions #2811

Merged
merged 5 commits into from Jul 3, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 1, 2023

📜 Description

We were setting the transactionFinishedCallback to transactionOptions, but were never calling it

💡 Motivation and Context

Internal discussions

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 304.80 ms 363.34 ms 58.54 ms
Size 1.72 MiB 2.29 MiB 575.02 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c03a05e 390.40 ms 419.35 ms 28.94 ms
dc67004 273.86 ms 346.37 ms 72.51 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms
0310da5 381.20 ms 404.50 ms 23.30 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms

App size

Revision Plain With Sentry Diff
c03a05e 1.72 MiB 2.29 MiB 574.43 KiB
dc67004 1.72 MiB 2.28 MiB 573.45 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
0310da5 1.72 MiB 2.28 MiB 573.45 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB

Previous results on branch: rz/fix/slow-frozen-frames

Startup times

Revision Plain With Sentry Diff
33a0ed5 297.79 ms 313.58 ms 15.80 ms
c1ac8b7 274.37 ms 317.44 ms 43.07 ms
79e7a47 323.68 ms 328.87 ms 5.19 ms

App size

Revision Plain With Sentry Diff
33a0ed5 1.72 MiB 2.29 MiB 575.02 KiB
c1ac8b7 1.72 MiB 2.29 MiB 575.02 KiB
79e7a47 1.72 MiB 2.29 MiB 575.02 KiB

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (581d779) 81.25% compared to head (b603fdb) 81.27%.

❗ Current head b603fdb differs from pull request most recent head 599613b. Consider uploading reports for the commit 599613b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2811      +/-   ##
============================================
+ Coverage     81.25%   81.27%   +0.01%     
- Complexity     4560     4562       +2     
============================================
  Files           350      350              
  Lines         16870    16871       +1     
  Branches       2274     2274              
============================================
+ Hits          13708    13712       +4     
+ Misses         2219     2216       -3     
  Partials        943      943              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Hub.java 75.17% <ø> (ø)
sentry/src/main/java/io/sentry/SentryTracer.java 94.98% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn enabled auto-merge (squash) July 3, 2023 11:02
@romtsn romtsn merged commit 4e809ac into main Jul 3, 2023
19 checks passed
@romtsn romtsn deleted the rz/fix/slow-frozen-frames branch July 3, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants