-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SDK unity-compatible #2847
Conversation
The only problem is that this change is binary-incompatible, so if someone is using an older integration version (e.g. |
Performance metrics 馃殌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
just a note, though. The public interfaces that were changed are technically a breaking change. A note in the changelog is enough, as it will be part of v7 anyway
馃摐 Description
Since sentry-unity consumes Android SDK artifacts decoupled from each other (e.g.
sentry.jar
andsentry-android-core.aar
do not know about each other), some versions of Unity cannot properly desugardefault
methods in interfaces during build time.This results in runtime errors when a
default
method fromsentry.jar
is called insentry-android-core.aar
. We've tried to work this around by properly consuming android artifacts using local maven (#2725), but this turned out to be a nightmare to support, because we modify gradle build files via regexes on sentry-unity.This PR simply converts all
default
methods that are used in sentry-android-core to be non-default (meaning proper implementations in each interface implementor).馃挕 Motivation and Context
@bitsandfoxes mental well-being
馃挌 How did you test it?
Manually and automated
馃摑 Checklist
sendDefaultPII
is enabled.馃敭 Next steps