-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate okhttp status to parent spans #2872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when OkHttp call finishes, status of unfinished spans is not overridden and is set to INTERNAL_ERROR
when OkHttp call finishes, status of unfinished spans is not overridden and is set to INTERNAL_ERROR
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
adf8fe3 | 300.49 ms | 357.36 ms | 56.87 ms |
f274c79 | 313.96 ms | 355.96 ms | 42.00 ms |
0310da5 | 381.20 ms | 404.50 ms | 23.30 ms |
caf50ec | 302.36 ms | 325.25 ms | 22.89 ms |
496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
496bdfd | 301.22 ms | 343.96 ms | 42.73 ms |
2718fc8 | 322.33 ms | 369.98 ms | 47.65 ms |
c03a05e | 390.40 ms | 419.35 ms | 28.94 ms |
87b3774 | 310.48 ms | 362.04 ms | 51.56 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
adf8fe3 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
0310da5 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
caf50ec | 1.72 MiB | 2.29 MiB | 575.24 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
2718fc8 | 1.72 MiB | 2.29 MiB | 575.53 KiB |
c03a05e | 1.72 MiB | 2.29 MiB | 574.43 KiB |
87b3774 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
=========================================
Coverage 81.38% 81.38%
Complexity 4645 4645
=========================================
Files 354 354
Lines 17114 17114
Branches 2313 2313
=========================================
Hits 13928 13928
Misses 2236 2236
Partials 950 950 ☔ View full report in Codecov by Sentry. |
markushi
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
status of OkHttp calls now gets propagated to parent span
when OkHttp call finishes, status of unfinished spans is not overridden and is set to INTERNAL_ERROR
💡 Motivation and Context
OkHttp calls are grouped in a tree of parent-children. If a child span fails with status
internal_error
, the parent span has a different status, but it should beinternal_error
, too.Fixes sentry-demos/android#60
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps