-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add send-modules option #2926
Add send-modules option #2926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've applied formatting and added the Option for Android Manifest. I'd like to give our Android specialists a chance to review this before approving and merging as this new option is useful for all SDK users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📜 Description
A new option to disable sending modules.
💡 Motivation and Context
I saw this option is in ruby options, but this option is not present in java options.
This option can be useful when you don't need to send a list of modules with versions.
When using sentry-spring-boot-starter you can use this option in application.yaml
💚 How did you test it?
I tested it using spring boot app
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps