Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark CRONS feature experimental #2944

Merged
merged 28 commits into from
Sep 25, 2023

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

Mark all CRONs related methods and classes @Experimental

💡 Motivation and Context

So we can more easily make changes.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to feat/crons-options September 20, 2023 11:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a0c8886

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.35 ms 430.73 ms 74.38 ms
Size 1.72 MiB 2.29 MiB 576.09 KiB

Previous results on branch: feat/crons-experimental

Startup times

Revision Plain With Sentry Diff
af2eb8f 367.40 ms 438.54 ms 71.14 ms
c34b4fe 349.94 ms 424.64 ms 74.70 ms

App size

Revision Plain With Sentry Diff
af2eb8f 1.72 MiB 2.29 MiB 576.09 KiB
c34b4fe 1.72 MiB 2.29 MiB 576.09 KiB

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 7c8c65c differs from pull request most recent head 522a7b5. Consider uploading reports for the commit 522a7b5 to get more accurate results

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One annotation missing, LGTM otherwise

@@ -266,5 +266,6 @@ SentryId captureTransaction(
}

@NotNull
@ApiStatus.Experimental
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the @ApiStatus.Experimental Annotation is missing on the SentryClient.java class

@adinauer adinauer self-assigned this Sep 25, 2023
Base automatically changed from feat/crons-options to feat/crons-lib-support September 25, 2023 12:32
@adinauer adinauer merged commit 7ef79c2 into feat/crons-lib-support Sep 25, 2023
11 of 14 checks passed
@adinauer adinauer deleted the feat/crons-experimental branch September 25, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants