Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer send schedule for Quartz check-ins, add a way to configure the monitor slug per quartz trigger #2948

Merged
merged 29 commits into from
Sep 25, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 25, 2023

#skip-changelog

📜 Description

No longer send schedule for quartz. Allow setting the monitor slug on triggers.

💡 Motivation and Context

Quartz uses its own CRON expressions which at the moment aren't compatible with our backend. So instead of trying to quickly change expressions to meet our format (and in the process maybe break them / change their meaning) we decided to not send schedule along with check-ins for quartz for now. We can iterate on this later on as we get feedback from users.

We also wanted a way to configure the monitor slug per trigger so users can set up their monitor in Sentry UI and not have to guess the automatically generated slug (which also changes if naming in the code changes).

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fc3404c

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 319.37 ms 413.54 ms 94.17 ms
Size 1.72 MiB 2.29 MiB 575.99 KiB

Previous results on branch: feat/crons-quartz-followup

Startup times

Revision Plain With Sentry Diff
0e68f0d 360.28 ms 431.10 ms 70.82 ms
aca09e3 419.80 ms 498.92 ms 79.12 ms

App size

Revision Plain With Sentry Diff
0e68f0d 1.72 MiB 2.29 MiB 575.99 KiB
aca09e3 1.72 MiB 2.29 MiB 576.09 KiB

@adinauer adinauer self-assigned this Sep 25, 2023
Base automatically changed from feat/crons-experimental to feat/crons-lib-support September 25, 2023 12:41
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 7cd0d0e differs from pull request most recent head fc3404c. Consider uploading reports for the commit fc3404c to get more accurate results

📢 Thoughts on this report? Let us know!.

@adinauer adinauer merged commit c65470b into feat/crons-lib-support Sep 25, 2023
13 of 15 checks passed
@adinauer adinauer deleted the feat/crons-quartz-followup branch September 25, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants