-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer send schedule for Quartz check-ins, add a way to configure the monitor slug per quartz trigger #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance metrics 🚀
|
…lug from merged job data map
Base automatically changed from
feat/crons-experimental
to
feat/crons-lib-support
September 25, 2023 12:41
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
lbloder
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
No longer send
schedule
for quartz. Allow setting the monitor slug on triggers.💡 Motivation and Context
Quartz uses its own CRON expressions which at the moment aren't compatible with our backend. So instead of trying to quickly change expressions to meet our format (and in the process maybe break them / change their meaning) we decided to not send
schedule
along with check-ins for quartz for now. We can iterate on this later on as we get feedback from users.We also wanted a way to configure the monitor slug per trigger so users can set up their monitor in Sentry UI and not have to guess the automatically generated slug (which also changes if naming in the code changes).
💚 How did you test it?
Manually
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps