Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap max number of stack frames to 100 to not exceed payload size limit #3009

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Oct 23, 2023

📜 Description

💡 Motivation and Context

Closes #2988

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 386.87 ms 405.44 ms 18.56 ms
Size 1.72 MiB 2.29 MiB 576.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
86f0096 381.33 ms 476.58 ms 95.25 ms
0bf143e 368.35 ms 437.47 ms 69.12 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms

App size

Revision Plain With Sentry Diff
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
0bf143e 1.72 MiB 2.29 MiB 576.50 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...c/main/java/io/sentry/SentryStackTraceFactory.java 89.65% <100.00%> (+0.36%) ⬆️

📢 Thoughts on this report? Let us know!.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@romtsn romtsn merged commit bc4be3b into main Oct 23, 2023
19 of 21 checks passed
@romtsn romtsn deleted the rz/fix/stackoverflow-not-captured branch October 23, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry can't catch stack/buffer overflow problem?
2 participants