Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send SDK frames in case of crashes #3021

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 2, 2023

馃摐 Description

  • Send SDK frames for uncaught exceptions to enable SDK detection on Java/Android

Here's a sample event for testing https://sentry-sdks.sentry.io/issues/4595173909/events/ea05056bfc2b4f42ae04df91a4745881/

馃挕 Motivation and Context

Closes #2758

馃挌 How did you test it?

Manually and automated

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@romtsn
Copy link
Member Author

romtsn commented Nov 2, 2023

@philipphofmann what would be the next step for ingesting crashes into the sentry org? I guess open a PR similar to this one? getsentry/sentry#59261

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 350.14 ms 413.53 ms 63.39 ms
Size 1.72 MiB 2.26 MiB 550.30 KiB

Baseline results on branch: feat/7.0.0

Startup times

Revision Plain With Sentry Diff
6684058 414.76 ms 511.46 ms 96.70 ms
6a40795 370.00 ms 437.33 ms 67.33 ms
ff784c6 388.51 ms 461.90 ms 73.39 ms
db8763d 386.60 ms 453.66 ms 67.06 ms

App size

Revision Plain With Sentry Diff
6684058 1.72 MiB 2.26 MiB 550.19 KiB
6a40795 1.72 MiB 2.26 MiB 550.26 KiB
ff784c6 1.72 MiB 2.26 MiB 550.22 KiB
db8763d 1.72 MiB 2.26 MiB 550.22 KiB

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Files Coverage 螖
...try/android/core/ActivityLifecycleIntegration.java 83.38% <100.00%> (+0.11%) 猬嗭笍
...a/io/sentry/android/core/AndroidTransportGate.java 100.00% <100.00%> (酶)
...roid/core/AppComponentsBreadcrumbsIntegration.java 89.06% <100.00%> (酶)
...o/sentry/android/core/AppLifecycleIntegration.java 68.25% <100.00%> (酶)
...ain/java/io/sentry/android/core/AppStartState.java 97.72% <100.00%> (+0.10%) 猬嗭笍
...try/android/core/DefaultAndroidEventProcessor.java 84.68% <100.00%> (-2.36%) 猬囷笍
.../android/core/EnvelopeFileObserverIntegration.java 83.33% <100.00%> (+0.57%) 猬嗭笍
...in/java/io/sentry/android/core/NdkIntegration.java 91.83% <100.00%> (酶)
...ry/android/core/NetworkBreadcrumbsIntegration.java 93.93% <100.00%> (酶)
...android/core/PhoneStateBreadcrumbsIntegration.java 84.09% <100.00%> (酶)
... and 112 more

... and 3 files with indirect coverage changes

馃摙 Thoughts on this report? Let us know!.

@philipphofmann
Copy link
Member

@philipphofmann what would be the next step for ingesting crashes into the sentry org? I guess open a PR similar to this one? getsentry/sentry#59261

I will collect all PRs and issues necessary to achieve this here getsentry/sentry#59263. Ideally, yes this PR and adding a config like this one https://github.com/getsentry/sentry/blob/4cef591aaa40a3579089da89b24a0fac12ce72e5/src/sentry/utils/sdk_crashes/cocoa_sdk_crash_detector.py, create a project in Sentry for the Java/Android crashes with some grouping rules.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM!

@romtsn romtsn merged commit 607e89b into feat/7.0.0 Nov 3, 2023
17 checks passed
@romtsn romtsn deleted the rz/feat/send-sdk-frames branch November 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants