Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved assertions after "assume" call #3045

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

stefanosiano
Copy link
Member

馃摐 Description

moved assertions after "assume" call

#skip-changelog

馃挕 Motivation and Context

The checkEnvelopeProfiledTransaction test is already skipped on headless emulator (agp matrix), but some assertions were done before the assume call, which is the one that skips the test. So sometimes those assertions could throw in the agp matrix workflow.
Fixes issues like https://github.com/getsentry/sentry-java/actions/runs/6814073423/job/18530091061?pr=3036

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review November 9, 2023 16:22
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 375.36 ms 442.81 ms 67.45 ms
Size 1.72 MiB 2.29 MiB 577.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2fad834 390.07 ms 470.80 ms 80.73 ms
283d83e 416.81 ms 497.22 ms 80.41 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
86f0096 381.33 ms 476.58 ms 95.25 ms
c3f503e 360.41 ms 434.67 ms 74.27 ms
3d8bd2b 379.45 ms 450.36 ms 70.90 ms
3d8bd2b 375.34 ms 446.32 ms 70.98 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms

App size

Revision Plain With Sentry Diff
2fad834 1.72 MiB 2.29 MiB 577.53 KiB
283d83e 1.72 MiB 2.29 MiB 577.69 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB

@stefanosiano stefanosiano merged commit 26e43ca into main Nov 10, 2023
22 checks passed
@stefanosiano stefanosiano deleted the skip-ui-test-headless branch November 10, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants