Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send breadcrumbs and client error even without transactions #3087

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

stefanosiano
Copy link
Member

馃摐 Description

moved breadcrumb sent before span null check in SentryOkHttpEvent
added client error reporting if call root span is null

馃挕 Motivation and Context

OkHttp breadcrumb and client error were not sent in case the span was not created, like when no transaction is running.
Fixes getsentry/sentry-android-gradle-plugin#606

馃挌 How did you test it?

Unit tests

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review December 6, 2023 14:57
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 415.34 ms 468.26 ms 52.92 ms
Size 1.72 MiB 2.27 MiB 554.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0404ea3 332.47 ms 401.12 ms 68.66 ms
2a3dd50 363.61 ms 440.18 ms 76.57 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
4e29063 384.14 ms 447.74 ms 63.60 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
8838e01 367.65 ms 447.40 ms 79.75 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
4e29063 376.38 ms 390.98 ms 14.60 ms

App size

Revision Plain With Sentry Diff
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
2a3dd50 1.72 MiB 2.27 MiB 555.05 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB

Previous results on branch: fix/okhttp-breadcrumb-no-span

Startup times

Revision Plain With Sentry Diff
326907b 405.09 ms 474.26 ms 69.16 ms

App size

Revision Plain With Sentry Diff
326907b 1.72 MiB 2.27 MiB 554.95 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@stefanosiano stefanosiano merged commit 4e260b3 into main Dec 6, 2023
19 checks passed
@stefanosiano stefanosiano deleted the fix/okhttp-breadcrumb-no-span branch December 6, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

okhttp crumbs missing
3 participants