Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend e2e tests #3127

Merged
merged 56 commits into from
Jan 24, 2024
Merged

Add backend e2e tests #3127

merged 56 commits into from
Jan 24, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jan 3, 2024

#skip-changelog

📜 Description

Add some end to end tests for backend.

💡 Motivation and Context

To catch breaking changes early.

💚 How did you test it?

;-)

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer requested a review from lbloder January 3, 2024 14:17
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 51a1121

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 390.16 ms 466.50 ms 76.34 ms
Size 1.70 MiB 2.27 MiB 583.82 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1f3652d 361.62 ms 424.76 ms 63.14 ms
86f0096 381.33 ms 476.58 ms 95.25 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
e6ffd7b 379.52 ms 449.30 ms 69.78 ms
0bd723b 412.52 ms 496.65 ms 84.13 ms
3d8bd2b 375.34 ms 446.32 ms 70.98 ms
4e260b3 384.08 ms 477.56 ms 93.48 ms
9119d59 407.12 ms 509.64 ms 102.52 ms
4e29063 376.38 ms 390.98 ms 14.60 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms

App size

Revision Plain With Sentry Diff
1f3652d 1.72 MiB 2.27 MiB 554.95 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
e6ffd7b 1.72 MiB 2.29 MiB 579.13 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
9119d59 1.70 MiB 2.27 MiB 583.84 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB

Previous results on branch: feat/backend-e2e-tests

Startup times

Revision Plain With Sentry Diff
eaea817 390.43 ms 461.30 ms 70.87 ms
b87fb2b 448.86 ms 531.02 ms 82.16 ms
6fb3a13 398.49 ms 436.70 ms 38.21 ms
06c4443 407.92 ms 485.69 ms 77.77 ms
1959d29 408.73 ms 486.68 ms 77.95 ms
fba097d 440.16 ms 511.28 ms 71.12 ms
df6f13d 456.69 ms 538.70 ms 82.01 ms
922dd4a 442.44 ms 496.39 ms 53.95 ms
02d7b93 395.77 ms 474.56 ms 78.79 ms
5a3dcb4 376.96 ms 443.90 ms 66.94 ms

App size

Revision Plain With Sentry Diff
eaea817 1.70 MiB 2.27 MiB 583.84 KiB
b87fb2b 1.72 MiB 2.27 MiB 558.56 KiB
6fb3a13 1.72 MiB 2.27 MiB 558.56 KiB
06c4443 1.72 MiB 2.27 MiB 558.42 KiB
1959d29 1.72 MiB 2.27 MiB 558.56 KiB
fba097d 1.72 MiB 2.27 MiB 558.56 KiB
df6f13d 1.72 MiB 2.27 MiB 558.56 KiB
922dd4a 1.72 MiB 2.27 MiB 558.56 KiB
02d7b93 1.70 MiB 2.27 MiB 583.82 KiB
5a3dcb4 1.72 MiB 2.27 MiB 558.30 KiB

@adinauer adinauer marked this pull request as ready for review January 11, 2024 11:33
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things and I didn't check the test code, only configs and gradle files, but LGTM otherwise 🚢

@adinauer adinauer self-assigned this Jan 15, 2024
@adinauer
Copy link
Member Author

Actuator has only been added to one of the sample projects and should be there for all so the ...wait for spring ... script doesn't wait the full duration but stops when the server is ready.

@adinauer
Copy link
Member Author

JUNIT test reports seem to override each other

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit bc46677 into main Jan 24, 2024
29 checks passed
@adinauer adinauer deleted the feat/backend-e2e-tests branch January 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants