Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hubs/Scopes Merge 3 - Replace IHub with IScopes in Android core #3299

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Hubs/Scopes Merge 3 - Replace IHub with IScopes in Android core #3299

merged 4 commits into from
Apr 16, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 2, 2024 •
edited

#skip-changelog

馃摐 Description

Follow up for #3297 changing Android core.

馃挕 Motivation and Context

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@adinauer adinauer changed the base branch from main to feat/hsm-2-replacements-in-core April 2, 2024 12:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against e9b5439

@adinauer adinauer marked this pull request as ready for review April 2, 2024 12:25
@adinauer adinauer mentioned this pull request Apr 2, 2024
Merged
7 tasks
lbloder
lbloder reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Base automatically changed from feat/hsm-2-replacements-in-core to 8.x.x April 16, 2024 14:37
@adinauer adinauer merged commit 30990f6 into 8.x.x Apr 16, 2024
2 of 4 checks passed
@adinauer adinauer deleted the feat/hsm-3-replacements-in-android-core branch April 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adinauer @markushi @lbloder