Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubs/Scopes Merge 13 - Replace IHub with IScopes in samples #3310

Merged
merged 14 commits into from
Apr 16, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 2, 2024

#skip-changelog

馃摐 Description

Follow up for #3297 changing samples.

馃挕 Motivation and Context

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against b85d772

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 384.64 ms 441.24 ms 56.61 ms
Size 1.70 MiB 2.28 MiB 592.27 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Base automatically changed from feat/hsm-12-replacements-in-spring-6-boot-3-integrations to 8.x.x April 16, 2024 14:46
@adinauer adinauer merged commit ec30e19 into 8.x.x Apr 16, 2024
9 of 10 checks passed
@adinauer adinauer deleted the feat/hsm-13-replacements-in-samples branch April 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants