Hubs / Scopes Merge 16 - Move client and throwable to span map to scope #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
|
adinauer
commented
Apr 4, 2024
| @@ -40,10 +36,6 @@ public final class Scopes implements IScopes, MetricsApi.IMetricsInterface { | |||
| private final @NotNull SentryOptions options; | |||
| private volatile boolean isEnabled; | |||
| private final @NotNull TracesSampler tracesSampler; | |||
|
|
|||
There was a problem hiding this comment.
Having a separate map per Scopes will break the feature since it's forked more often than hub used to be (at least for non mobile).
adinauer
commented
Apr 4, 2024
| @@ -85,6 +90,11 @@ public final class Scope implements IScope { | |||
|
|
|||
| private @NotNull ISentryClient client = NoOpSentryClient.getInstance(); | |||
|
|
|||
| // TODO intended only for global scope | |||
| // TODO test for memory leak | |||
There was a problem hiding this comment.
This needs testing once enough changes have been implemented to check for memory leaks.
There was a problem hiding this comment.
Agree, we might have to remove the entries that have been sent to Sentry from the map.
But this would have been an issue with Hub as well I think.
adinauer
changed the title
markushi
approved these changes
Apr 18, 2024
lbloder
approved these changes
Apr 19, 2024
| @@ -85,6 +90,11 @@ public final class Scope implements IScope { | |||
|
|
|||
| private @NotNull ISentryClient client = NoOpSentryClient.getInstance(); | |||
|
|
|||
| // TODO intended only for global scope | |||
| // TODO test for memory leak | |||
There was a problem hiding this comment.
Agree, we might have to remove the entries that have been sent to Sentry from the map.
But this would have been an issue with Hub as well I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Move client and throwable to span map to scope.
💡 Motivation and Context
Both shall be on global scope by default.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps