Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubs/Scopes Merge 20 - Use separate scope for current, isolation and global scope #3344

Merged
merged 25 commits into from
Apr 19, 2024

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

  • Use separate scope for current, isolation and global scope
  • Rename mainScopes to rootScopes
  • Rename cloneMainHub to forkedRootScopes

TODO: We need to figure out how to deal with global scope. It should already be available before Sentry.init is called but Scope requires SentryOptions e.g. to set some limits. At the moment we're replacing global scope on init but that should be changed in a follow up PR.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ce17684

Base automatically changed from feat/hsm-19-push-isolation-scope-fork to 8.x.x April 19, 2024 12:26
@adinauer adinauer merged commit 385666d into 8.x.x Apr 19, 2024
4 of 20 checks passed
@adinauer adinauer deleted the feat/hsm-20-use-separate-scopes branch April 19, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants