Hubs/Scopes Merge 21 - Allow controlling which scope configureScope uses
#3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
…ainScopes to rootScopes
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
markushi
approved these changes
Apr 18, 2024
| @@ -169,8 +169,8 @@ public void withScope(@NotNull ScopeCallback callback) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void configureScope(@NotNull ScopeCallback callback) { | |||
| scopes.configureScope(callback); | |||
| public void configureScope(@Nullable ScopeType scopeType, @NotNull ScopeCallback callback) { | |||
There was a problem hiding this comment.
m: I guess we should do the same for withScope
There was a problem hiding this comment.
Yeah, will add in a follow up PR.
There was a problem hiding this comment.
Ah, this has the same problem as having an overload for forkedScope where withScope(ISOLATION) ... forks both isolation and current scope which might be confusing.
Maybe having another method called withIsolationScope, as RFC suggests, is better but very similar.
There was a problem hiding this comment.
Adding withIsolationScope in a follow up PR
lbloder
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
A default
ScopeTypecan be set inSentryOptionswhich defaults toISOLATIONfor JVM (backend, etc.) andCURRENTfor Android. This default scope is then used forconfigureScopewhen no explicitScopeTypeis passed.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps