Hubs Scopes Merge 29 - Mark TODOs related to Hubs/Scopes Merge with [HSM] #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
…ainScopes to rootScopes
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
adinauer
requested review from
lbloder
and removed request for
markushi,
romtsn and
stefanosiano
|
Performance metrics 🚀
|
adinauer
commented
Apr 16, 2024
| @@ -435,7 +434,7 @@ public void bindClient(@NotNull ISentryClient client) { | |||
|
|
|||
| @Override | |||
| public @NotNull ISentryClient getClient() { | |||
| // TODO checking for noop here doesn't allow disabling via client, is that ok? | |||
| // TODO [HSM] checking for noop here doesn't allow disabling via client, is that ok? | |||
There was a problem hiding this comment.
Should a customer want to disable Sentry this way, they can provide their own implementation of ISentryClient that is noop but not detected as such here.
markushi
approved these changes
Apr 19, 2024
lbloder
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
💡 Motivation and Context
So we can more easily find relevant TODOs again.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps