Hubs/Scopes Merge 37 - Fix combined Contexts
#3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
…ainScopes to rootScopes
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
Performance metrics 🚀
|
markushi
approved these changes
Apr 22, 2024
| return internalStorage.size(); | ||
| } | ||
|
|
||
| public int getSize() { |
There was a problem hiding this comment.
Do we need both a size() and getSize()? If so, maybe you can add some clarifying comment describing why.
There was a problem hiding this comment.
It was to allow kotlin to use .size without brackets. Is there another way to achieve that?
There was a problem hiding this comment.
Added some comments to Contexts to explain why each is needed.
lbloder
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
We extended
ConcurrentHashMap, exposing lots of stuff as public API and making it hard to combineContexts. I've now moved this map into a property we forward to. We can add additional API that was there with the map extension if needed.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps