Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSM 43a Fix Android Tests Alternative #3418

Merged
merged 2 commits into from
May 14, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented May 13, 2024

#skip-changelog

…t and a disabled one## 📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@lbloder lbloder changed the title add DisabledSentryClient to distinguish between scopes with noopclien… HSM 43a Fix Android Tests Alternative May 13, 2024
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.31 ms 445.22 ms 59.91 ms
Size 1.70 MiB 2.28 MiB 595.97 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test is fixed in another PR. We can go with this test behaviour for now. In case it's flaky we can change what we assert.

@adinauer adinauer marked this pull request as ready for review May 14, 2024 05:11
@adinauer adinauer merged commit 9114f94 into 8.x.x May 14, 2024
21 of 24 checks passed
@adinauer adinauer deleted the hsm-43a-fix-android-tests-alternative branch May 14, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants