Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 6 - Use OpenTelemetry span status for Sentry span API #3439

Merged
merged 59 commits into from
Jun 18, 2024

Conversation

adinauer
Copy link
Member

📜 Description

We serialize sentry SpanStatus into the description of the OpenTelemetry spans status.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
Copy link
Contributor

github-actions bot commented May 23, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 6 - Use OpenTelemetry span status for Sentry span API ([#3439](https://github.com/getsentry/sentry-java/pull/3439))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5d07cb0

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 375.98 ms 463.70 ms 87.72 ms
Size 1.70 MiB 2.28 MiB 596.05 KiB

Baseline results on branch: feat/potel-5-start-end-timestamp-data-tags

Startup times

Revision Plain With Sentry Diff
178acf8 355.93 ms 427.23 ms 71.30 ms

App size

Revision Plain With Sentry Diff
178acf8 1.70 MiB 2.28 MiB 595.96 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/potel-5-start-end-timestamp-data-tags to 8.x.x June 18, 2024 05:32
@adinauer adinauer merged commit 504ef52 into 8.x.x Jun 18, 2024
1 of 19 checks passed
@adinauer adinauer deleted the feat/potel-6-sync-status branch June 18, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants