New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle os.arch value of 'amd64' in the Android Gradle Plugin. #455

Merged

bretthoerner merged 1 commit into master from plugin-arch-fix

Jul 5, 2017

bretthoerner commented Jul 5, 2017 •

edited

The issue wasn't the classloader, it's that os.arch is amd64 and not x86_64 as the sentry-cli binary is named and so the file isn't found.

It gets weird because it seems like some JVMs may actually report x86_64, so I just handled this one (common) case for now.


          Handle os.arch value of 'amd64' in the Android Gradle Plugin.

2b1c9b1

bretthoerner requested a review from mitsuhiko

July 5, 2017 19:29

bretthoerner mentioned this pull request

Proguard support #317

Closed

mitsuhiko approved these changes

View reviewed changes

bretthoerner merged commit dd8c717 into master

bretthoerner deleted the plugin-arch-fix branch

July 11, 2017 20:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment